Open TheSilentDawn opened 2 years ago
Technically, this is not a bug because it works and is syntactically valid. As for how sane it looks, I suppose we could do better.
In general, we should refrain from adding quotation marks in the intermediate path variables, and only add them where the path variable is actually "consumed."
In that sense, the above should be changed to set(LIBC_LIBRARY_DIR_FLAG "-L\"${LIBC_LIBRARY_DIR}\"")
.
But I am no CMake expert, and @tejlmand can probably provide better insight.
In general, we should refrain from adding quotation marks in the intermediate path variables, and only add them where the path variable is actually "consumed."
... In that sense, the above should be changed to
set(LIBC_LIBRARY_DIR_FLAG "-L\"${LIBC_LIBRARY_DIR}\"")
.
Completely agree. We should do this at the final place where it's consumed.
Thanks for your prompt reply
@tejlmand does this require any action, i.e. apply the change proposed above?
Describe the bug The Zephyr SDK generates incorrect link command when using newlibc.
To Reproduce
Impact Wrong linking command
Logs and console output The option in the link.txt looks like this
The quotation mark position should at the end
Environment (please complete the following information):