search

zephyrproject-rtos / zephyr

Primary Git Repository for the Zephyr Project. Zephyr is a new generation, scalable, optimized, secure RTOS for multiple hardware architectures.
https://docs.zephyrproject.org
Apache License 2.0
10.79k stars 6.58k forks source link

drivers: wifi: esp_at: doesn't actually support AT v1.7's DNS query #40447

Open ycsin opened 2 years ago

ycsin commented 2 years ago

The esp8266 AT driver doesn't actually supports DNS query (4431ae5119ca08b69839e3623ea8de0e483ccf86) on AT commands v1.7.

Current implementation is based on AT v2.0, for v1.7:

  1. dns command is AT+CIPDNS_CUR instead of AT+CIPDNS.
  2. the returned command also seems to be different, not +CIPDNS:enable[,"DNS IP1"[,"DNS IP2"[,"DNS IP3"]]]

image

extra context

The driver seems to work if I change the dns handler to:

    char **servers = (char **)argv;
    size_t num_servers = argc;

along with the necessary command change

ycsin commented 2 years ago

@mniestroj any idea?

mniestroj commented 2 years ago

@ycsin I was not testing that with ESP-AT 1.7 and have little interest in implementing DNS query with 1.7 myself (besides keeping old functionality still working). But any pull requests are welcome!

ycsin commented 2 years ago

@mniestroj thanks for the reply. Its response seems to be in multiple lines, I'm not sure how to handle the second one and so on, but I'll submit a PR if I have something, at least disabling that DNS option when 1.7 is selected so that there's no surprise.

zephyrbot commented 8 months ago

Hi @krish2718, @jukkar,

This issue, marked as an Enhancement, was opened a while ago and did not get any traction. It was just assigned to you based on the labels. If you don't consider yourself the right person to address this issue, please re-assing it to the right person.

Please take a moment to review if the issue is still relevant to the project. If it is, please provide feedback and direction on how to move forward. If it is not, has already been addressed, is a duplicate, or is no longer relevant, please close it with a short comment explaining the reason.

@ycsin you are also encouraged to help moving this issue forward by providing additional information and confirming this request/issue is still relevant to you.

Thanks!

jukkar commented 8 months ago

There does not seem to be anyone in maintainers file that would handle esp_at wifi driver, but I found in codeowners file the driver so assigning to @mniestroj