zephyrproject-rtos / zephyr

Primary Git Repository for the Zephyr Project. Zephyr is a new generation, scalable, optimized, secure RTOS for multiple hardware architectures.
https://docs.zephyrproject.org
Apache License 2.0
10.77k stars 6.57k forks source link

Samples / Tests without a testcase.yaml or sample.yaml #47613

Closed nashif closed 2 years ago

nashif commented 2 years ago

Describe the bug

The following samples and tests do no have an meta data to allow them to be run via twister:

A few bsim tests were also found, but those are being run differently.

To Reproduce

Looks a the directories above and find that there are no yaml files.

Expected behavior All code in the tree needs to be tested, or at least built, to avoid bitrot.

Impact Bitrot.

fabiobaltieri commented 2 years ago

Assigning to @nashif for coordination, guess the owners of the individual tests should take care of them.

carlocaione commented 2 years ago

@MaureenHelm did you mean to close this? Still several tests to be addressed.

MaureenHelm commented 2 years ago

@MaureenHelm did you mean to close this? Still several tests to be addressed.

It auto-closed when I merged #47810

aasthagr commented 2 years ago

@nashif I think a yaml file is not needed for the samples listed below as they are the sub-applications being built as part of the main application using the main sample.yaml.

The "tests/cmake/config_dir/foo" just contains a config file (referred to from the main sample tests/cmake/config_dir) and is not an application to be built separately.

The test case tests/arch/xtensa_asm2 doesn't exist as it was removed #47710.

Working to submit the fix for samples/subsys/shell/devmem_load. Let me know if you have feedback on any of the above.

nashif commented 2 years ago

@aasthagr something like samples/subsys/ipc/openamp/remote can be built and that is the point with the sample.yml, it can be marked as build_only for now so that it does not bitrot if it is not a standalone application. The least I expect is a README explaining how this is used and how it relates to other samples so there is no confusion.

If it get complicated, please open sepearate issues with the reamining items and assign them to respective owners