up_squared: sample: gpio_counter - is failing

[KamilxPaszkiet]

Describe the bug

DEBUG   - DEVICE: Succeed to download NBP file.
DEBUG   - DEVICE: *** Zephyr EFI Loader ***
DEBUG   - DEVICE: RSDP found at 0x79c34000
DEBUG   - DEVICE: Zeroing 4816352 bytes of memory at 0x106000
DEBUG   - DEVICE: Copying 32768 data bytes to 0x1000 from image offset
DEBUG   - DEVICE: Copying 24576 data bytes to 0x100000 from image offset 32768
DEBUG   - DEVICE: Copying 2109984 data bytes to 0x59dde0 from image offset 57344
DEBUG   - DEVICE: Jumping to Entry Point: 0x1137 (48 31 c0 48 31 d2 48)
DEBUG   - DEVICE: *** Booting Zephyr OS build zephyr-v3.3.0-2743-g3f06e5ac6069 ***
DEBUG   - DEVICE: ERROR: cannot set HAT pin 35 to OUT (-22)

The README contains BIOS settings for this test. I looked in the bios and checked the settings, everything looks fine...

To Reproduce Steps to reproduce the behavior:

twister --device-testing --hardware-map $HOME/up2_double.yaml -T samples/boards/up_squared/gpio_counter/ --no-skipped-report -vv

or

west build -p -b up_squared -T samples/boards/up_squared/gpio_counter/

Expected behavior The test should pass:

*** Booting Zephyr OS build zephyr-v2.6.0-2360-gc94e53c9f5b6 ***
counter: 0x0
counter: 0x1
counter: 0x2
counter: 0x3
counter: 0x4
counter: 0x5
counter: 0x6
counter: 0x7
counter: 0x8
counter: 0x9
counter: 0xa
counter: 0xc
counter: 0xd
counter: 0xe
counter: 0xf

• OS: Ubuntu for the controller
• Toolchain: Zephyr SDK 15.0
• Latest mainline 2be2fa8

[nashif]

This same is old and seems to be unmaintained, consider dropping it.

[github-actions[bot]]

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

[nashif]

@KamilxPaszkiet is the bios set for this test per the requirements?

Requirements
************

The application requires an UP Squared board connected to the PC through USB
for serial console. The BIOS settings must be updated as specified in the
source code comments for HAT Configurations (see table above).

* Note:
 * Need to change the BIOS settings:
 * () Advanced -> HAT Configurations:
 *    - HD-Audio / I2S6 Selec -> Disabled
 *    - GPIO / PWM3 Selection -> GPIO
 *    - GPIO / I2S2 Selection -> GPIO
 *
 *    - GPIO 19 (Pin16) Confi -> Input
 *
 *    - GPIO 14 (Pin35) Confi -> Output
 *    - GPIO 15 (Pin37) Confi -> Output
 *    - GPIO 27 (Pin38) Confi -> Output
 *    - GPIO 28 (Pin40) Confi -> Output

[KamilxPaszkiet]

@KamilxPaszkiet is the bios set for this test per the requirements?

Requirements
************

The application requires an UP Squared board connected to the PC through USB
for serial console. The BIOS settings must be updated as specified in the
source code comments for HAT Configurations (see table above).

* Note:
 * Need to change the BIOS settings:
 * () Advanced -> HAT Configurations:
 *    - HD-Audio / I2S6 Selec -> Disabled
 *    - GPIO / PWM3 Selection -> GPIO
 *    - GPIO / I2S2 Selection -> GPIO
 *
 *    - GPIO 19 (Pin16) Confi -> Input
 *
 *    - GPIO 14 (Pin35) Confi -> Output
 *    - GPIO 15 (Pin37) Confi -> Output
 *    - GPIO 27 (Pin38) Confi -> Output
 *    - GPIO 28 (Pin40) Confi -> Output

Yes, ofc.

But output is slightly different than in May:

DEBUG   - DEVICE: >>Checking Media Presence......
DEBUG   - DEVICE: >>Media Present......
DEBUG   - DEVICE: Downloading NBP file...
DEBUG   - DEVICE: 
DEBUG   - DEVICE: Succeed to download NBP file.
DEBUG   - DEVICE: *** Zephyr EFI Loader ***
DEBUG   - DEVICE: RSDP found at 0x79c34000
DEBUG   - DEVICE: Zeroing 4870224 bytes of memory at 0x108000
DEBUG   - DEVICE: Copying 32768 data bytes to 0x1000 from image offset
DEBUG   - DEVICE: Copying 32768 data bytes to 0x100000 from image offset 32768
DEBUG   - DEVICE: Copying 2264992 data bytes to 0x5ad060 from image offset 65536
DEBUG   - DEVICE: Jumping to Entry Point: 0x1137 (48 31 c0 48 31 d2 48)
DEBUG   - DEVICE: *** Booting Zephyr OS build zephyr-v3.5.0-467-gdc431a7397a6 ***
DEBUG   - DEVICE: ERROR: cannot set HAT pin 40 to OUT (-22)

[jhedberg]

I am able to reproduce this with the same cannot set HAT pin 40 to OUT (-22) error. The "check_perms()" step in the gpio_intel.c driver is failing, i.e. the HW is claiming that the host OS doesn't have permissions to change the specific pin. I think it's likely that this is simply some firmware/BIOS issue, i.e. something has changed in more recent versions, which probably requires different settings, or perhaps updating the sample to use different pins. I don't have any bandwidth to work on this any further however, so the options are to either remove this sample (or possibly mark GPIO as unsupported on APL) or to just close this as not planned.

[KamilxPaszkiet]

I am able to reproduce this with the same cannot set HAT pin 40 to OUT (-22) error. The "check_perms()" step in the gpio_intel.c driver is failing, i.e. the HW is claiming that the host OS doesn't have permissions to change the specific pin. I think it's likely that this is simply some firmware/BIOS issue, i.e. something has changed in more recent versions, which probably requires different settings, or perhaps updating the sample to use different pins. I don't have any bandwidth to work on this any further however, so the options are to either remove this sample (or possibly mark GPIO as unsupported on APL) or to just close this as not planned.

@nashif What do you think?

[github-actions[bot]]

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

[github-actions[bot]]

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

[jhedberg]

@KamilxPaszkiet I don't have access to this hardware anymore, so someone else would need to pick this up.

[jhedberg]

@KamilxPaszkiet I don't have access to this hardware anymore, so someone else would need to pick this up.

Also see https://github.com/zephyrproject-rtos/zephyr/issues/58057#issuecomment-1822492625 - it doesn't look like this is a bug in a driver or board definition, rather it's BIOS or test case related.