search

zephyrproject-rtos / zephyr

Primary Git Repository for the Zephyr Project. Zephyr is a new generation, scalable, optimized, secure RTOS for multiple hardware architectures.
https://docs.zephyrproject.org
Apache License 2.0
10.91k stars 6.64k forks source link

OTS - OACP Indications sent before write rsp #66023

Closed piotrnarajowski closed 7 months ago

piotrnarajowski commented 11 months ago

Describe the bug OTS test cases require that at least one object stored on the IUT is initialized as Current Object. This is achieved by Lower Tester performing procedure as desrcibed in section 4.2.4. of OTS TS. According to subsection 6. of this preamble procedure, "The IUT, after sending a Write Response to acknowledge the write to the Object List Control Point, sends an indication of the Object List Control Point characteristic.". Unfortunately, zephyr in a first place is sending indication of the OLCP characteristic followed by write response.

To Reproduce Can be reproduced with AutoPTS

Expected behavior According to OTP spec section 4.4.4.: "An OLCP or OACP operation is started when the ATT Write Response is received from the Object Server as a result of the Object Client writing an Op Code to a control point to perform some desired action. The control point operation ends when the Object Server sends an indication to the Object Client with the Op Code set to Response Code.". This suggests that correct order while performing OLCP or OACP operations should be Write Response First, Indication second.

Impact Unable to pass any OTS test case that require operations on objects.

Logs and console output OTS_SR_CR_BV_02_C_2023_12_01_10_52_20.zip

Environment (please complete the following information):

Thalley commented 11 months ago

Thanks for reporting this. @jhedberg I am unsure I and Asbjørn should be assigned to this, as we did not write the server implementation (I think that was @kapi-no ?), and this will be very low priority for us.

github-actions[bot] commented 9 months ago

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

piotrnarajowski commented 9 months ago

Please remove the stale label as this is the reason why over 30 OTS test cases fail.

github-actions[bot] commented 7 months ago

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

jhedberg commented 7 months ago

Is @kapi-no the right assignee for this? There doesn't seem to be much interest (or effort) for getting this fixed.

Thalley commented 7 months ago

I guess not. I'll assign it back to me, as it's related to some LE Audio tests (even though the implementation is not).

sjanc commented 7 months ago

Fixed in https://github.com/zephyrproject-rtos/zephyr/pull/71679