zephyrproject-rtos / zephyr

Primary Git Repository for the Zephyr Project. Zephyr is a new generation, scalable, optimized, secure RTOS for multiple hardware architectures.
https://docs.zephyrproject.org
Apache License 2.0
10.9k stars 6.64k forks source link

Able to leave off stop bit for I2C transactions on nRF52/nRF53 #69488

Open RobMeades opened 8 months ago

RobMeades commented 8 months ago

We are users of the nRF52/nRF53 and its I2C drivers, with which we had no problem.

When getting the same code to work on STM32, we raised issue https://github.com/zephyrproject-rtos/zephyr/issues/69290 on the STM32 I2C driver as we had found that the STM32 driver forced I2C_MSG_STOP at the end of every transfer; we didn't want this as we wanted to perform a write without a stop bit, followed by a read, as separate transfers.

@teburd has pointed out that the STM32 behaviour is the correct one, I2C_MSG_STOP should be forced by the I2C driver at the end of every transaction and a note has been added to the I2C API to this effect (see https://github.com/zephyrproject-rtos/zephyr/pull/69484/files).

We have changed our implementation to work with this but @teburd asked if we could raise on issue on the nRF52/nRF53 drivers for NOT forcing I2C_MSG_STOP at the end of a transfer.

Issue hereby raised.

aescolar commented 8 months ago

CC @Mierunski @awojasinski

github-actions[bot] commented 6 months ago

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

nordic-piks commented 2 months ago

FYI @kl-cruz Triaged internally

kl-cruz commented 2 months ago

@bjarki-andreasen We need to check whether this configuration is possible in our hardware

github-actions[bot] commented 3 weeks ago

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.