search

zephyrproject-rtos / zephyr

Primary Git Repository for the Zephyr Project. Zephyr is a new generation, scalable, optimized, secure RTOS for multiple hardware architectures.
https://docs.zephyrproject.org
Apache License 2.0
10.34k stars 6.34k forks source link

PDF generation is broken when a page has images in WebP format #70990

Closed kartben closed 1 month ago

kartben commented 4 months ago

Describe the bug

As part of #60204, a documentation page that includes images in WebP format was introduced. LaTeX does not allow WebP images to be included and as a result the generation of the documentation in PDF format fails.

To Reproduce

cd ~/zephyrproject/zephyr/doc
rm _build -Rf && cmake -GNinja -B_build . -DDT_TURBO_MODE=1 && cd _build && ninja latex

Expected behavior

Build succeeds and WEBP images (or their equivalent in another supported format) are correctly embedded in the PDF.

Impact

PDF available at https://docs.zephyrproject.org/latest/zephyr.pdf is incomplete

Additional context

The following PR would allow us to properly instruct Sphinx to convert WebP files to PNG prior to building the PDF https://github.com/sphinx-doc/sphinx/pull/12224

kartben commented 3 months ago

As https://github.com/sphinx-doc/sphinx/pull/12224 has been merged, PDF generation should be working again as soon as a new Sphinx release is out 🤞🏼

github-actions[bot] commented 1 month ago

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

kartben commented 1 month ago

Fixed in Sphinx upstream