zephyrproject-rtos / zephyr

Primary Git Repository for the Zephyr Project. Zephyr is a new generation, scalable, optimized, secure RTOS for multiple hardware architectures.
https://docs.zephyrproject.org
Apache License 2.0
9.92k stars 6.1k forks source link

drivers: video: ov7670: introduce driver for ov7670 camera #72826

Closed danieldegrasse closed 1 week ago

danieldegrasse commented 4 weeks ago

Introduce driver for ov7670 camera, supporting QCIF,QVGA,CIF, and VGA resolution in YUV and RGB mode.

danieldegrasse commented 3 weeks ago

neat! For the record, could you add in the commit message the board/devkit with wich you tested this.

Sure- it was tested on the FRDM-MCXN947, but that support requires PR #72827, which is dependent on this driver. I can add something like the following to the commit message:

Support was verified on the FRDM-MCXN947, using the SmartDMA camera engine, which is enabled in the following PR: https://github.com/zephyrproject-rtos/zephyr/pull/72827

Would this work?

loicpoulain commented 3 weeks ago

Support was verified on the FRDM-MCXN947, using the SmartDMA camera engine, which is enabled in the following PR: #72827

Would this work?

Sure.

danieldegrasse commented 1 week ago

@loicpoulain could you revisit this PR when you get a chance? I've updated the commit message as requested

danieldegrasse commented 1 week ago

@ngphibang or @josuah, FYI in case either of you would like to provide feedback.

danieldegrasse commented 1 week ago

@decsny would you be willing to review this when you have a chance (or @galak, I'd just like someone to take a look at this from the DTS side based on the assignee the bot selected)

decsny commented 1 week ago

the binding is fairly trivial, reassigning to video area

ngphibang commented 1 week ago

LGTM ! +1

dleach02 commented 1 week ago

@loicpoulain can you return to this PR for final review