zephyrproject-rtos / zephyr

Primary Git Repository for the Zephyr Project. Zephyr is a new generation, scalable, optimized, secure RTOS for multiple hardware architectures.
https://docs.zephyrproject.org
Apache License 2.0
10.67k stars 6.52k forks source link

Bluetooth: Audio: BAP Broadcast Assistant fails on broadcast_id = 0x000000 #79189

Open larsgk opened 2 weeks ago

larsgk commented 2 weeks ago

Describe the bug With a broadcast ID of 0x000000, the BAP Broadcast Assistant fails validity check for broadcast_id.

The issue seems that on reset, broadcast_id gets set to 0 and later comparison with a broadcast ID of 0x000000 then get's faulty detected as "already added".

To Reproduce Add a broadcast source with broadcast ID 0x000000

Expected behavior The broadcast source is added to the connected sink.

Impact Although unlikely (1 of 2^24 combinations), broadcast ID = 0x000000 can't be added.

Logs and console output N/A

Suggested solution Assign a value higher than 0xFFFFFF (largest broadcast ID) to broadcast_id on reset.

Thalley commented 2 weeks ago

@larsgk Please use the bug template when reporting bugs. Please update this bug report to contain the requested information