search

zephyrproject-rtos / zephyr

Primary Git Repository for the Zephyr Project. Zephyr is a new generation, scalable, optimized, secure RTOS for multiple hardware architectures.
https://docs.zephyrproject.org
Apache License 2.0
10.92k stars 6.65k forks source link

tests: Bluetooth: tester: add xg24_rb4187c board #81702

Open kedMertens opened 1 day ago

kedMertens commented 1 day ago

Adds overlay and config files to tester app for xg24_rb4187c silabs board. Overlay enables uart for BTP communication and config file enables RTT logging.

github-actions[bot] commented 1 day ago

Hello @kedMertens, and thank you very much for your first pull request to the Zephyr project! Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary. If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

jhedberg commented 1 day ago

@kedMertens thanks! There seems to be a bunch of Compliance check failures - please fix those.

kedMertens commented 1 day ago

@kedMertens thanks! There seems to be a bunch of Compliance check failures - please fix those.

Sorry about that, didn't setup pre hooks to check locally, I'm on it.

jerome-pouiller commented 1 day ago

I believe this change is not sufficient to have xg24_rb4187c included in the CI. Am I right? Is it expected? Do we need to list xg24_rb4187c in testcase.yaml?

kedMertens commented 1 day ago

I believe this change is not sufficient to have xg24_rb4187c included in the CI. Am I right? Is it expected? Do we need to list xg24_rb4187c in testcase.yaml?

Not sure, the tester app is meant to be used for running qualification tests with auto-pts framework. Do you mean that there is a CI job to build the app?

Thalley commented 1 day ago

I believe this change is not sufficient to have xg24_rb4187c included in the CI. Am I right? Is it expected? Do we need to list xg24_rb4187c in testcase.yaml?

Not sure, the tester app is meant to be used for running qualification tests with auto-pts framework. Do you mean that there is a CI job to build the app?

Indeed.

You need to add the platform to https://github.com/zephyrproject-rtos/zephyr/blob/main/tests/bluetooth/tester/testcase.yaml if you want CI to build it

jhedberg commented 1 day ago

You need to add the platform to https://github.com/zephyrproject-rtos/zephyr/blob/main/tests/bluetooth/tester/testcase.yaml if you want CI to build it

The upstream CI policy is to never build any configuration that depends on binary blobs, and this board is such a configuration (the Silabs Bluetooth Link Layer is binary-only in a Zephyr context). Is there a risk that upstream CI might try to build this configuration if it's added? If yes, then it shouldn't be added there, rather there should just be a forced explicit platform selection in downstream CI.