zephyrproject-rtos / zephyr

Primary Git Repository for the Zephyr Project. Zephyr is a new generation, scalable, optimized, secure RTOS for multiple hardware architectures.
https://docs.zephyrproject.org
Apache License 2.0
10.92k stars 6.65k forks source link

samples: net: cellular_modem: Add additional overlay for nrf7002dk #81724

Open ethansisk opened 23 hours ago

ethansisk commented 23 hours ago

This overlay is for the nrf7002dk. The modem tested was the Telit ME310G1-WW, but should work for any of the supported modems provided that the UART lines are defined and hooked up correctly.

github-actions[bot] commented 23 hours ago

Hello @ethansisk, and thank you very much for your first pull request to the Zephyr project! Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary. If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

bjarki-andreasen commented 16 hours ago

For local board modifications, one should use snippets locally. Local board modifications can't go upstream since overlays apply to the base board, so the overlay would be applied, likely incorrectly, to everyone elses local board, which could be configured very differently :)

To run the cellular sample with snippets, you would create the snippet with the overlay you add in this PR (named "nrf7002dk_telit" in this example), then build the sample like

west build -p -b nrf7002dk/nrf5340/cpuapp --snippet nrf7002dk_telit zephyr/samples/net/cellular_modem

With the base board and snippet, you have a "custom" local board you use for any in-tree sample

tomi-font commented 6 hours ago

@bjarki-andreasen Isn't this already done with some of the DT overlays already present? I mean yeah, I see why we might not want to have something like a "hardcoded" modem compatible in such an overlay. But having at least part of that overlay readily available could be useful to users, if something like that is feasible.

bjarki-andreasen commented 4 hours ago

We can add the overlay as a snippet to tbe sample