zepinglee / citeproc-lua

A Lua implementation of the Citation Style Language (CSL)
MIT License
62 stars 7 forks source link

OSCOLA: unexpected "nil" in footnote (type article-magazine) #58

Closed daniel-eder closed 3 months ago

daniel-eder commented 3 months ago

Describe the bug The type article-magazine (and also article-journal) produces an unexpected "nil" in the footnote. The bibliography seems fine.

Additional information

To Reproduce https://github.com/daniel-eder/reproduce-oscola-csl-error

Screenshots Screenshot from my generated pdf - notice the "nil" after "Analytics India Magazine" image

Compared to the result from Zotero: image

I am not sure which value citeproc-lua is missing and thus replacing with "nil". It is not the page number, I tried to add a page number in an additional citation (article-journal) and it prints the nil before the page number: image

zepinglee commented 3 months ago

Ah, this is because I forgot to consider empty page variable in previous 022f606. Fixed in 4c3eeb4.

daniel-eder commented 3 months ago

you are my saviour, thank you!

daniel-eder commented 3 months ago

Tested locally and works, thanks again