zeplin / fastlane-plugin-notarize

fastlane plugin to notarize a macOS app 🛂
MIT License
68 stars 8 forks source link

Add early stapling option #6

Closed jnross closed 5 years ago

jnross commented 5 years ago

Fixes #5.

Ruby is not a strong language for me, so feel free to point at places this could be factored better and I will fix it.

But it works in my testing!

jnross commented 5 years ago

I added a config item try_early_stapling which is required to enable early staple attempts. I'm not sure that I picked the best name, am open to suggestions there.

Would it be helpful to you if I bump the version in version.rb?

berkcebi commented 5 years ago

Thanks a bunch @jnross, this is great!

jnross commented 5 years ago

Thanks for working with me on this. I'm happy with the changes that landed.