search

zeplin / storybook-zeplin

Storybook addon to view Zeplin resources in story panel
https://storybook-zeplin.netlify.app
MIT License
115 stars 16 forks source link

Bug on v1.7.3 ? linked component does not load. #72

Open ovaxio opened 1 year ago

ovaxio commented 1 year ago

storybook v6.5.15 storybook-zeplin v1.7.3

Steps to reproduce

create a MDX story and define the zeplinLink parameter on the component or component

<Meta
  title="Components/Button"
  component={Button}
  parameters={{
    zeplinLink: "zpl://components?pid=...&coids=..."
  }}
/>

Tested also with JSX story without success.

Current behavior

There is no connected component for this story. printed in the panel

Expected behavior

showing the linked component from Zeplin in the Panel

Some Digging

I checked the source code of storybook-zeplin plugin and found that the useLink hook has the storyId as useEffect dependency and was changed from zeplinLink in v1.7.2 in this commit

I change the version to v1.7.2 and now the expected behavior works fine.