Closed sanjay-io closed 5 years ago
@ink-spot this PR is removing a trivial file, correct me if I'm wrong though. Is it okay to merge?
@SanjayTCP Maybe this PR solve this issue https://github.com/ink-spot/UPCarouselFlowLayout/issues/35
Yup, I believe that we're forced to use the new build system in Xcode 10
In xcode 10 the New Build System is default, I changed to Legacy Build System and its worked.
Added #38 that also fixes this issue by tweaking the podspec. Hopefully @ink-spot will accept one of them. 🤞
Along with the Swift 4.2 PR, this one needs to be merged in order for the hosting app to be able to build.
How do we merge
I am not sure how to execute the merging
Sent from my iPhone
On Sep 24, 2018, at 1:17 PM, Drew Pitchford notifications@github.com wrote:
Along with the Swift 4.2 PR, this one needs to be merged in order for the hosting app to be able to build.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.
Someone with write privileges for this PR or repo has to do it I think.
Drew
Sent from my iPhone XS Max
On Sep 24, 2018, at 12:24 PM, paskalem notifications@github.com wrote:
I am not sure how to execute the merging
Sent from my iPhone
On Sep 24, 2018, at 1:17 PM, Drew Pitchford notifications@github.com wrote:
Along with the Swift 4.2 PR, this one needs to be merged in order for the hosting app to be able to build.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.
Thank you very much for the advice. Pascale
Sent from my iPhone
On Sep 24, 2018, at 1:43 PM, Drew Pitchford notifications@github.com wrote:
Someone with write privileges for this PR or repo has to do it I think.
Drew
Sent from my iPhone XS Max
On Sep 24, 2018, at 12:24 PM, paskalem notifications@github.com wrote:
I am not sure how to execute the merging
Sent from my iPhone
On Sep 24, 2018, at 1:17 PM, Drew Pitchford notifications@github.com wrote:
Along with the Swift 4.2 PR, this one needs to be merged in order for the hosting app to be able to build.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.
Thanks again
Looks like https://github.com/ink-spot/UPCarouselFlowLayout/pull/41 fixes this as well. Thanks all. Closing!
This Info.plist is causing issues on Xcode 9's new build system.