Conversion to Swift 4.2

[andre991]

Conversion to swift 4.2

Issue #42

[andre991]

@ink-spot @SirArkimedes @0ber

[itruf]

+1

This fix is required to build for Swift 4.2

[drewpitchford]

Can we get this merged? I love the pod...but need the update.

[paskalem]

I don’t know if I can be of any help, but I was thinking that maybe It wasn’t a coincidence if I got this email , Sincerely yours

Sent from my iPhone

On Sep 20, 2018, at 3:51 PM, Drew Pitchford notifications@github.com wrote:

Can we get this merged? I love the pod...but need the update.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[rajeshbeats]

This is indeed update..

[paskalem]

🤞

Sent from my iPhone

On Sep 21, 2018, at 3:50 AM, Rajesh notifications@github.com wrote:

This is indeed update..

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[paskalem]

Thanks

Sent from my iPhone

On Sep 21, 2018, at 9:14 AM, Andrew Robinson notifications@github.com wrote:

@SirArkimedes requested changes on this pull request.

I'll get the ball rollin'!

In UPCarouselFlowLayoutDemo.xcodeproj/project.pbxproj:

@@ -402,11 +419,13 @@ buildSettings = { ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES; ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;

• DEVELOPMENT_TEAM = X4EYDGL7NV; It looks like there previously wasn't a development team set, should this be here?

In UPCarouselFlowLayout/UPCarouselFlowLayout.swift:

@@ -60,7 +59,7 @@ open class UPCarouselFlowLayout: UICollectionViewFlowLayout {

     let yInset = (collectionSize.height - self.itemSize.height) / 2
     let xInset = (collectionSize.width - self.itemSize.width) / 2

• self.sectionInset = UIEdgeInsetsMake(yInset, xInset, yInset, xInset)
• self.sectionInset = UIEdgeInsets.init(top: yInset, left: xInset, bottom: yInset, right: xInset) I think the .init part shouldn't be here, as it looks like the isn't used in other places.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[drewpitchford]

If everyone agrees with the changes made, can we merge this? I think it is good to go.

[paskalem]

Okay let’s try it

Sent from my iPhone

On Sep 24, 2018, at 11:09 AM, Drew Pitchford notifications@github.com wrote:

If everyone agrees with the changes made, can we merge this? I think it is good to go.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[zepojo]

Sorry guys I've been very busy lately and I just got a chance to look at that. Thanks a lot for your contribution, I'll merge it right away!