utils: add rmtree - Githubissues

zeppelinos / zos-lib

:warning: Deprecated repo in favour of https://github.com/zeppelinos/zos

https://zeppelinos.org/

62 stars 29 forks source link

utils: add rmtree #148

Closed come-maiz closed 6 years ago

come-maiz commented 6 years ago

Requested by @facuspagnuolo in https://github.com/zeppelinos/zos-cli/pull/207#discussion_r190370380

come-maiz commented 6 years ago

Thanks for the review @facuspagnuolo. I pushed the changes.

come-maiz commented 6 years ago

@facuspagnuolo the package-lock.json was generated with ^ on the versions, which afaict is wrong because it's not pinning the exact version installed. But I'm not an expert on this. I've proposed https://github.com/zeppelinos/zos-lib/pull/167 to just review that as a prerequisite for this PR.

facuspagnuolo commented 6 years ago

@elopio I think it should be because of your NPM version, we are using 6.0.1. I'd prefer updating the package-lock just for the new dependency, not all of them

come-maiz commented 6 years ago

Is there a magic command that updates only the lock for one dependency?

facuspagnuolo commented 6 years ago

I don't think so, please update NPM and commit the new package-lock file

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 613

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.08%

Totals
Change from base Build 611:	0.0%
Covered Lines:	95
Relevant Lines:	95

💛 - Coveralls

come-maiz commented 6 years ago

@facuspagnuolo ok, I installed the newer npm and now npm install doesn't change the one from master at all. Can you please add to the README the info about the required versions to contribute?