search

zeppelinos / zos-lib

:warning: Deprecated repo in favour of https://github.com/zeppelinos/zos
https://zeppelinos.org/
62 stars 29 forks source link

Remove synchronous web3.js calls #205

Closed frangio closed 6 years ago

frangio commented 6 years ago

We found one usage of web3.js without a callback, which results in a blocking call.

https://github.com/zeppelinos/zos-lib/blob/c7e3254c01f7513d78bdcfd4141d3305009b6a9c/src/utils/Proxy.js#L21

We want to use asynchronous calls everywhere, otherwise for example we won't be able to implement #172. We should find all instances where web3.js is being used synchronously and add a callback, or consider using a promisified version of web3.js (buidler's?).

s1na commented 6 years ago

I'd like to give this a try, if it's okay with you guys.

facuspagnuolo commented 6 years ago

For sure @s1na, thanks!

spalladino commented 6 years ago

Hey @s1na! Please keep us posted on how it's going with this issue, and if you need any help. Thanks!

s1na commented 6 years ago

@spalladino Hi! Sry it's been some time, I was struggling with #206 and didn't make much progress on this. Please let me know if this is high priority so that either I can spend more time on it, or let someone else work on it instead.