[Bug 🐞]: Incorrect mod settings descriptions/labels

[johnnycocas]

Brief description of your issue (aka the problem)

In-game mod settings are not being correctly mapped to the text keys in the Localization file, as shown in one of the attached print screens containing the contents of the DLL included in the mod.

Operating system

Win10

KSP version

1.12.3.3173

Version of addon

2.2.0.0

Steps to reproduce the behavior or issue

1. Open "Settings"
2. Open "Difficulty Options"
3. Select "OhScrap! (OHS) Options"

Expected behavior

In-game settings text keys being mapped with the prefix "#OHS".

Actual behavior

Settings keys are being mapped with the prefix "#FND".

Environment

Mod: v2.2.0.0
KSP: v1.12.3.3173
Installation: CKAN

Log files

KSP.log

Screenshots

In-game screenshot:

DLL contents:

Localization file (expected values):

Additional context

Edited to add a label to each image.

How did you download and install this?

CKAN (auto install with dependencies)

[zer0Kerbal]

@johnnycocas thank you for a wonderful bug report (the report is wonderful - not the bug)

if not - will be for the next - will comment later -

again, thank you!

[zer0Kerbal]

I believe this has been fixed internally - just not released (sooner than soon)

[johnnycocas]

Yeah the code in the repository seemed to be correct, at least on the 2.2.99.0 branch (master seemed to contain legacy code) so I assumed maybe the DLL was compiled with old code and said code was changed afterwards. Weird thing nonetheless, iirc "FND" should be for "Foundations", another of your mods, correct? Maybe some code found a way across to the other side 😁

Don't thank me too much, I may find more bugs in the future xD