Closed keyspace closed 1 year ago
Testing - no display issues so far, no NREs...
No new bugs or new NREs on "live" save so far.
(Pic: One new booster in tandem with four old ones.)
IMO worth mentioning on next release that some parts that "never used to fail" now "perform as advertised".
IMO worth mentioning on next release that some parts that "never used to fail" now "perform as advertised".
just plain deviously worded😂. I will mention that. 😁
Closes #46 as fixed. Closes #91 as duplicate (might have comments that are different issues?..).
Some mods modify existing nodes/modules in parts, others replace them; sometimes this happens in a chained manner.
Not all parts fail the same way, too, so OhScrap adds different
*FailureModule
s across many files, often with rules on ordering, depending on which compatible mod is addressed.In the touched ModuleManager patch, all parts that already have a
*FailureModule
also get aModuleUPFMEvents
.Before this commit, RemoteTech antennas would get a
RTAntennaFailureModule
after theModuleUPFMEvents
patch has already run (and you don't get a second pass). This was because RemoteTech parts would only get their*FailureModule
after getting aModuleRTAntenna
, different from antennas untouched by RT, which get a*FailureModule
based on having aModuleDataTransmitter
, itself different from a customModuleRTDataTransmitter
...After this commit, parts having a
*FailureModule
are guaranteed to have aModuleUPFMEvents
. We do get a second pass!This commit may also activate warranty and immediately expire it on all parts that were supposed to fail long ago, but were unable to communicate their intent to OhScrap.
More on ModuleManager patch ordering:
https://github.com/sarbian/ModuleManager/wiki/Patch-Ordering