[Bug 🐞]: Repairing control surfaces (non-FAR) enables all axes

[Darael]

Brief description of your issue (aka the problem)

When a control surface (first noticed with Firespitter biplane parts, but later I observed it with stock elevons also, so I'm assuming it's a general issue) has an OHS failure and is repaired, it is enabled for all control axes, regardless of which axes were enabled before failure.

Operating system

Debian Testing

KSP version

1.12.5

Version of addon

2.2.0.0 (CKAN)

Steps to reproduce the behavior or issue

• Install OHS and launch a vessel with new, low-generation control surface parts (to ensure rapid failure).
• Disable some axes on these control surfaces — eg, set elevators to pitch only.
• Fly until such a control surface fails
• Repair the control surface.

Expected behavior

The control surface returns to its configuration before failure, acting on inputs for only the originally-selected control axes (yaw, pitch, roll).

Actual behavior

All axes are enabled for the control surface, though any symmetry partners are left as they are. This can (and usually does) break input symmetry.

Environment

OhScrap! 2.2.0.0 from CKAN
No other mods besides OHS dependencies are required to manifest the issue, but I first noticed it with parts from Firespitter.
KSP 1.12.5

Log files

No response

Screenshots

No response

Additional context

No response

How did you download and install this?

CKAN (auto install with dependencies)

[github-actions[bot]]

:+1: Thank you @Darael :octocat:

:question::grey_question:

Have you reviewed the open issues logs and recent changelogs?

In order to help us help you, please provide:

• /KSP.LOG
• and one of the following:
  • if Module Manger is installed
  • /GameData/ModuleManager.ConfigCache
  • if Module Manger /L is installed
  • /PluginData/ModuleManager/ConfigCache.cfg
• Screenshots of issue (if appropriate) (images tell a much stronger tale)

You can archive these files (rar or zip, sadly no 7zip) and drag-n-drop them into an issue comment

:vibration_mode::eyes:Please either watch this repositiory for updates.

:speech_balloon:Kindly read our simple guides to:

• contributing
• our expected code of conduct (hint: we are all adults here)
• our style guide.md These are boilerplate.'

[zer0Kerbal]

@Darael thank you - will look into

@Lisias