zer0Kerbal / SimpleConstruction

Provides simple craft building capability in flight mode to stock parts for Kerbal Space Program.
https://forum.kerbalspaceprogram.com/index.php?/topic/191424-*/
GNU General Public License v3.0
6 stars 7 forks source link

[Bug 🐞]: Ghosted parts still appear in Community Category Kit Filter #123

Closed RobotGuy closed 2 years ago

RobotGuy commented 2 years ago

Brief description of your issue

When viewing the parts under the SimpleConstruction! filter in the VAB you can still see the ghosted parts

Steps to reproduce

Expected behavior

Not to be able to see the ghosted parts

Actual behavior

You can see the ghosted parts

Environment

Mod : Version SimpleConstruction-4.0.99.7-prerelease-CF
KSP : Version 1.12.3.3173 (BG 1.7.1, MK1.12.1)
Downloaded : Curseforge

How did you download and install this?

CurseForge (download and manual installation)

github-actions[bot] commented 2 years ago

Thank you. Kindly read contributiing.md, code_of_conduct.md and styleguide.md. These are boilerplate.

RobotGuy commented 2 years ago

As a quick fix, I added to the ghosting patch in /Config/SimpleConstruction/Tanks.crf, the following:

@tags:NEEDS[B9PartSwitch|InterstellarFuelSwitch] ^= :\s*cck-sc cck-el\s*: :

And to the patch in /Compatibility/ghostparts.cfg, the following:

@tags ^= :\s*cck-sc cck-el\s*: :

Thus removing the CCK tags. This made the ghosted tanks go away.

zer0Kerbal commented 2 years ago

Thank you @RobotGuy !

Having issues with my computer, went on a trip and unplugged the dev machine, turns out the CMOS battery died, and the BIOS went back to A05 from A25... i'm on the backup machine - but will attempt to push this one out.