zer0Kerbal / SimpleConstruction

Provides simple craft building capability in flight mode to stock parts for Kerbal Space Program.
https://forum.kerbalspaceprogram.com/index.php?/topic/191424-*/
GNU General Public License v3.0
6 stars 7 forks source link

[Bug 🐞]: Incompatibility with KSPCommunityFixes mod #164

Closed MartyrKomplx closed 1 year ago

MartyrKomplx commented 1 year ago

Brief description of your issue (aka the problem)

With both SCON and KSPCF (KSPCommunityFixes) installed, resource requirements (Rocketparts & Electric Charge) occasionally don't show when opening the crafting menu. Additionally, for the craft that shows no requirements, when attempting to build it, it will build instantly with no resources used.

Operating system

Windows 10

KSP version

1.12.3

Version of addon

4.0.99.30-prerelease <Launchpad 30> edition

Steps to reproduce the behavior or issue

  1. Install both SCON and KSPCF.
  2. Load craft with capability to construct craft (I used just simple mk1 capsule with docking port and full container of rocketparts)
  3. Open SCON build window and load/build a craft. (my test build was just an mk1 capsule)

Expected behavior

Display required resources. Build using resources, Build time not instantaneous.

Actual behavior

Occasionally (but repeatably) required resources don't show up on build dialogs and builds complete instantaneously.

Environment

SCON Mod: 4.0.99.30-prerelease
Downloaded: https://www.curseforge.com/kerbal/ksp-mods/sc/download/3924243

KSPCF Mod: 1.22.2
Downloaded: CKAN

Log files

KSP.log

Screenshots

screenshot11

Additional context

Tested on an install with only these two mods to verify. Works as expected without KSPCF, works as above with KSPCF. Also tested with EL (Extraplanetary Launchpads) since SCON was based on it. EL works as expected, leaving me to believe it was part of what was changed between EL and SCON.

How did you download and install this?

CurseForge (download and manual installation)

github-actions[bot] commented 1 year ago

Thank you. Kindly read contributiing.md, code_of_conduct.md and styleguide.md. These are boilerplate.

zer0Kerbal commented 1 year ago

Thank you for the great bug report (the 🐛 isn't great - but the ℹ️ report is) @MartyrKomplx !

I will look into this this weekend: have you told @taniwha and @gotmachine about this? (XPL and KSPCF)

MartyrKomplx commented 1 year ago

Thank you for the great bug report (the 🐛 isn't great - but the ℹ️ report is) @MartyrKomplx !

I will look into this this weekend: have you told @taniwha and @gotmachine about this? (XPL and KSPCF)

Just opened an issue on KSPCF.

Additionally: the bug appears to be independent from the part-count of the craft, or whether they were "modded" parts. A simple Mk1 capsule caused the issue, but more complex satellites/stations with (for example) parts from SSPX did not necessarily. But it's not completely random since the same craft-plan will always behave the same way (as far as I've observed).

zer0Kerbal commented 1 year ago

Will look into it

zer0Kerbal commented 1 year ago

issue is with CF/Harmony.

unable to legally use those mods due to issues with reverse engineering and copyright law in my local.

closed.

zer0Kerbal commented 1 year ago

issue probably is that kspcf replaces docking nodes. file: kspcf/MMPatches/ModSupport/FixDockingNodes.cfg