[Bug 🐞]:`System.FormatException: Input string was not in a correct format` on some parts

Lisias commented 1 year ago

Brief description of your issue (aka the problem)

Some SYL parts are not being able to be compiled by the Part Compiler:

[LOG 14:32:00.676] PartLoader: Compiling Part 'SpaceY/SpaceYLifters/Parts/Docking/syl-docking3m/syl-docking3m'
[ERR 14:32:00.687] PartLoader: Encountered exception during compilation. System.FormatException: Input string was not in a correct format.
  at System.Number.StringToNumber (System.String str, System.Globalization.NumberStyles options, System.Number+NumberBuffer& number, System.
Globalization.NumberFormatInfo info, System.Boolean parseDecimal) [0x00057] in <9577ac7a62ef43179789031239ba8798>:0
  at System.Number.ParseInt32 (System.String s, System.Globalization.NumberStyles style, System.Globalization.NumberFormatInfo info) [0x0001
3] in <9577ac7a62ef43179789031239ba8798>:0
  at System.Int32.Parse (System.String s) [0x00007] in <9577ac7a62ef43179789031239ba8798>:0
  at PartLoader.ParsePart (UrlDir+UrlConfig urlConfig, ConfigNode node) [0x00806] in <46478292153440df94e04a2a2ddd1062>:0
  at (wrapper dynamic-method) PartLoader+<CompileParts>d__56.PartLoader+<CompileParts>d__56.MoveNext_Patch0(PartLoader/<CompileParts>d__56)

[ERR 14:32:00.688] PartCompiler: Cannot compile part

This other part is also are affected:

[LOG 14:32:00.689] PartLoader: Compiling Part 'SpaceY/SpaceYLifters/Parts/Docking/syl-docking3m/SYdocking3m'

Operating system

ALL

KSP version

ALL

Version of addon

latest

Steps to reproduce the behavior or issue

n/a

Expected behavior

n/a

Actual behavior

n/a

Environment

n/a

Log files

n/a

Screenshots

n/a

Additional context

n/a

How did you download and install this?

Other (explain below)

github-actions[bot] commented 1 year ago

:+1: Thank you @Lisias :octocat:

:question::grey_question:

Have you reviewed the open issues logs and recent changelogs?

In order to help us help you, please provide:

/KSP.LOG
and one of the following:
- if Module Manger is installed
- /GameData/ModuleManager.ConfigCache
- if Module Manger /L is installed
- /PluginData/ModuleManager/ConfigCache.cfg
Screenshots of issue (if appropriate) (images tell a much stronger tale)

You can archive these files (rar or zip, sadly no 7zip) and drag-n-drop them into an issue comment

:vibration_mode::eyes:Please either watch this repositiory for updates.

:speech_balloon:Kindly read our simple guides to:

contributing
our expected code of conduct (hint: we are all adults here)
our style guide.md These are boilerplate.'

UltraJohn commented 1 year ago

Hi, I think this part is also affected:

[LOG 02:46:42.365] PartLoader: Part 'SpaceY/SpaceYLifters/Parts/Docking/syl-docking5m/syl-docking5m' has no database record. Creating.
[EXC 02:46:42.375] NullReferenceException: Object reference not set to an instance of an object
    PartLoader.GetDatabaseConfig (Part p) (at <4b449f2841f84227adfaad3149c8fdba>:0)
    PartLoader.GetDatabaseConfig (Part p, System.String nodeName) (at <4b449f2841f84227adfaad3149c8fdba>:0)
    DragCubeSystem.LoadDragCubes (Part p) (at <4b449f2841f84227adfaad3149c8fdba>:0)
    (wrapper dynamic-method) Part+<Start>d__323.Part+<Start>d__323.MoveNext_Patch0(Part/<Start>d__323)
    UnityEngine.SetupCoroutine.InvokeMoveNext (System.Collections.IEnumerator enumerator, System.IntPtr returnValueAddress) (at <12e76cd50cc64cf19e759e981cb725af>:0)
    UnityEngine.DebugLogHandler:LogException(Exception, Object)
    ModuleManager.UnityLogHandle.InterceptLogHandler:LogException(Exception, Object)
    UnityEngine.Debug:CallOverridenDebugHandler(Exception, Object)
[EXC 02:46:42.381] NullReferenceException: Object reference not set to an instance of an object
    PartLoader.GetDatabaseConfig (Part p) (at <4b449f2841f84227adfaad3149c8fdba>:0)
    PartLoader.GetDatabaseConfig (Part p, System.String nodeName) (at <4b449f2841f84227adfaad3149c8fdba>:0)
    DragCubeSystem.LoadDragCubes (Part p) (at <4b449f2841f84227adfaad3149c8fdba>:0)
    (wrapper dynamic-method) Part+<Start>d__323.Part+<Start>d__323.MoveNext_Patch0(Part/<Start>d__323)
    UnityEngine.SetupCoroutine.InvokeMoveNext (System.Collections.IEnumerator enumerator, System.IntPtr returnValueAddress) (at <12e76cd50cc64cf19e759e981cb725af>:0)
    UnityEngine.DebugLogHandler:LogException(Exception, Object)
    ModuleManager.UnityLogHandle.InterceptLogHandler:LogException(Exception, Object)
    UnityEngine.Debug:CallOverridenDebugHandler(Exception, Object)

zer0Kerbal commented 1 year ago

thank you @UltraJohn @Lisias !

I will fix this immediately locally, and will also run a regex find/replace to see if any other parts are suffering from a 🐒 'comma' on the back.

Plan is to release all the remaining parts in this coming release; they won't be fully upgraded but will be included due to an advance to the Ghostparts.cfg tech improvement.

zer0Kerbal / SpaceYLifters