zer0Kerbal / SpaceYLifters

Parts for large lifting rockets, 5m rocket parts and large SRBs, and matching decouplers for Kerbal Space Program.
https://forum.kerbalspaceprogram.com/index.php?/topic/209445-*/
2 stars 4 forks source link

[Request]: Make engine model switching use the stock ModulePartVariants as opposed to requiring Interstellar Fuel Switch #39

Open Nico314159 opened 1 year ago

Nico314159 commented 1 year ago

Description of the new feature / enhancement

Right now, the Kiwi, Moa, and Ratite don't allow you to switch between mounted and bare variants unless you install either Firespitter or Interstellar Fuel Switch. This is a relic from old versions before ModulePartVariants was introduced to the stock game. As such, I think these should be switched over to use ModulePartVariants instead

Proposed technical implementation details

It's 100% possible to completely swap engine models using ModulePartVariants (see: stock Poodle and Mainsail), so I think it would be good to make the Kiwi, Moa, and Ratite (and Penguin/Emu in Expanded) use this method as well. It would both improve consistency and eliminate a dependency. I understand you are busy, but this would be an extremely helpful fix to make when you have the time for it

zer0Kerbal commented 1 year ago

thank you for this suggestion @Nico314159 👍

I am working on updating this as we speak and this repo will see great changes shortly.

Once I have all the previous releases (archival) done I will push an adoption release - followed by several -prereleases which will allow me to update this glorious mod in a more manageable method.

When I get to these parts I shall probably use your suggestion, along with keeping the B9PS as a separate patch.

Nico314159 commented 1 year ago

In fact, part of the annoying thing about this is that it doesn't actually seem to even work with B9PS at the moment, it needs specifically either IFS or Firespitter.

Nico314159 commented 1 year ago

I also noticed that a number of parts are in incorrect categories that do not match stock parts of the same type (or SpaceY Expanded parts for that matter):

Nico314159 commented 1 year ago

I also noticed that a number of parts are in incorrect categories that do not match stock parts of the same type (or SpaceY Expanded parts for that matter):

* The docking ports are in Utility, but should be in Coupling.

* The 3.75m/5m stack decouplers/seperators and the two radial decouplers are all in Structural, but should be in Coupling.

* The 5m fairing is in Aerodynamics, but should be in Payload.

* The 5m heatshield is in Aerodynamics, but should be in Thermal.

* The landing legs are in Utility, but should be in Ground.

Ignore this, I was using the 1.10 version of the mod instead of the latest 1.17.2.