search

zer0c14 / gitinspector

Automatically exported from code.google.com/p/gitinspector
GNU General Public License v3.0
0 stars 0 forks source link

filter-in functionality #52

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
filter-out functionality a little bit is odd.

please add filter-in feature
example) gitinspector.py -i "email:(?!(sky.com))" Project/

from JK

Original issue reported on code.google.com by av9...@gmail.com on 22 Dec 2014 at 12:49

GoogleCodeExporter commented 9 years ago 
Problem is what to do when you mix include and exclude rules. They could be 
evaluated in the order that they are given; however, the behaviour wouldn't be 
very clear and would bring up some problems when include is introduced as a git 
config parameter (git config gitinspector.include) -- execution order wouldn't 
be obvious. Also, only one of each can then be given - Meaning you wouldn't be 
able to mix them properly.

The only "clean" option would be to redo it to work some other way (maybe a 
--filter parameter with "include/exclude as arguments).

In any case, as gitinspector supports regular expressions, you can use that to 
invert the filtering to get the same functionality that you are asking for. See 
the [Documentation] for more information on this.

In conclusion, In my opinion, it's  not worth the hassle and wouldn't add any 
new functionality.

/Adam Waldenberg

Original comment by gitinspe...@ejwa.se on 23 Dec 2014 at 2:31