zer0dt / hodlocker

https://hodlocker.com
GNU General Public License v3.0
16 stars 6 forks source link

Added link to github source on clicking HL logo #8

Closed usselman closed 8 months ago

usselman commented 8 months ago

Added link to github source on clicking HL logo, considering there is already a home button on the lower navigation bar.

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hodlocker ❌ Failed (Inspect) Jan 25, 2024 7:37pm
remjx commented 8 months ago

I think logo should remain as link to homepage which is standard practice. GitHub logo should be used as indicator to developers to signal site is open source.

Maybe move the user wallet balance in top right of header to action bar, and replace wallet balancewith GitHub logo? Generally top right is reserved for user profile, but currently that is action bar...

I don't see a great place for this right now...

usselman commented 8 months ago

Good points, happy to take @zer0dt direction on this. Perhaps a floating footer section underneath the bottom navigation bar, could hold github logo and link to 100 lockers chat, twitter link etc

zer0dt commented 8 months ago

Good points, happy to take @zer0dt direction on this. Perhaps a floating footer section underneath the bottom navigation bar, could hold github logo and link to 100 lockers chat, twitter link etc

I'm thinking putting these links on the nav menu when clicking on the avatar on the app / action bar. Would leave display looking clean but links easily accessible.

zer0dt commented 8 months ago
Screenshot 2024-01-25 154710

Something like this. So a divider and then the Github, Twitter icons (https://react-icons.github.io/react-icons/) in the same row on the last row and whatever other links are needed on top of the icons.

remjx commented 8 months ago

See https://github.com/zer0dt/hodlocker/pull/19

remjx commented 8 months ago

Closing since #19 was merged