Open zeratax opened 4 years ago
https://github.com/ZerataX/yacx/blob/master/include/yacx/Exception.hpp#L81 seems really weird to me to put the logger here? any uncaught exception ends up on std:cerr anyways, no?
Also think https://github.com/ZerataX/yacx/blob/master/include/yacx/Exception.hpp#L115 the file and line should have the same format as the logger: [file:linenumber]
[file:linenumber]
also feel like it shouldn't be called nvidiaException and more like yacx exception or something like that?
https://github.com/ZerataX/yacx/blob/master/src/Program.cpp#L63-L64
also think it's weird that we don't just log the log and instead use this exception specialty function
https://github.com/ZerataX/yacx/blob/master/include/yacx/Exception.hpp#L81 seems really weird to me to put the logger here? any uncaught exception ends up on std:cerr anyways, no?
Also think https://github.com/ZerataX/yacx/blob/master/include/yacx/Exception.hpp#L115 the file and line should have the same format as the logger:
[file:linenumber]
also feel like it shouldn't be called nvidiaException and more like yacx exception or something like that?
https://github.com/ZerataX/yacx/blob/master/src/Program.cpp#L63-L64
also think it's weird that we don't just log the log and instead use this exception specialty function