zerebos / BBDInstaller

Installer for the BetterDiscord fork BandagedBD
Other
212 stars 115 forks source link

Handle download failures better (Windows) #2

Closed Basic0 closed 5 years ago

Basic0 commented 5 years ago

Hi,

I've got a fairly restrictive firewall that requests permission before allowing new applications to make outbound requests to the internet.

It does this by controlling access to the network. As such, the first time an app attempts to connect, it will receive an "Access Denied" exception.

When this happens, the firewall pops up a prompt and I approve, meaning any further requests would succeed.

Most apps will re-try a download after a back off period, or off a manual "retry".

The BBD installer doesn't handle this scenario well;

Some things I've noticed;

• The download fails silently and isn't re-tried. • Even the "detailed" view doesn't show the download failure, just the "Downloading to ..." • If the download fails, the install seems to hang • The "Exit" button gives no indication that the process succeeded/failed [after the install hung, I left it 5 minutes then clicked Exit. Wasn't sure if it had succeeded, so re-ran just in case. It hadn't]

While making multiple attempts to download would be ideal for me, I acknowledge it's a pretty rare edge-case.

That said, I think there's a strong argument for improving the error handling to cope with temporary DNS/network glitches. At the very least, show the error message and change the "Exit" button to read "Cancel"/similar [I'm assuming that if you haven't got as far as downloading, there's nothing to really roll back].

In any case, many thanks for all your efforts. Hope this helps.