search

zerebos / BetterDiscordAddons

A series of plugins and themes for BetterDiscord.
Other
595 stars 408 forks source link

[Bug] [BetterRoleColors] App crashes when viewing user info in Lightcord #276

Closed asorel1942 closed 3 years ago

asorel1942 commented 4 years ago

Which plugin/theme is this about?

BetterRoleColors Describe the Bug

While the plugin is activated, clicking on a user's profile picture or name to see user info in a server results in the program crashing. To Reproduce

Run Lightcord, enable plugin, attempt to click on user's name or profile picture in server. Expected Behavior

For the server info popup to appear. Screenshots

Discord Version

Lightcord, BD, and OS versions are as follows: image

Additional Context

asorel1942 commented 4 years ago

After going into the settings for the plugin, disabling the Username and Enable Fallback options under the Popout section removed the issue; leaving Nickname on did not cause crashes. Whatever the issue is, it has to do with how colored usernames are being treated in the popout specifically.

zerebos commented 4 years ago

This issue is known, however do note that I do not support lightcord and in the future will not accept issues from those using it.

zerebos commented 4 years ago

This crash should be fixed (although the colors are not), can you confirm?

asorel1942 commented 4 years ago

I can confirm, yes. No longer crashing with those options enabled, although colors don't appear, as you say.

asorel1942 commented 4 years ago

Crash issue appears to be happening again when the color username option is enabled.

zerebos commented 3 years ago

This does not seem to be happening on BD, is it happening for you still?

asorel1942 commented 3 years ago

Cannot say for certain as I have the option turned off, and am not currently able to turn it on due to being unable to change settings for the plugin. Once your plugin library updates and I am able to modify settings, I will let you know.

zerebos commented 3 years ago

The update for the library was just pushed out

asorel1942 commented 3 years ago

Didn't register on my end until just now, apologies. The new version of the plugin is giving me a "This plugin might be dangerous (Account Stealer/Virus)" error, which I believe is an issue with Lightcord and not your plugin. image

asorel1942 commented 3 years ago

Update pushed through, as of version 1.2.27 of the plugin library and 0.8.13 of BetterRoleColors, activating the color username option still results in a crash of Lightcord upon activating the user popup for a user with an unchanged nickname.

zerebos commented 3 years ago

Are you on Discord stable? Popouts are currently working for me just fine. image

asorel1942 commented 3 years ago

As I said in the OP, I'm using Lightcord.

zerebos commented 3 years ago

As far as I can tell, Lightcord still pulls in Discord's code, but I don't know what stream. This seems to be a Lightcord only issue anyways and Lightcord is not a supported platform for my plugins.