zerebubuth / openstreetmap-cgimap

A C++ implementation of the OpenStreetMap API map call.
http://wiki.openstreetmap.org/wiki/Cgimap
GNU General Public License v2.0
74 stars 38 forks source link

Basic auth removal #362

Closed mmd-osm closed 7 months ago

mmd-osm commented 9 months ago

Merging only after #354 is done.

mmd-osm commented 8 months ago

Well, Basic Auth isn't that huge, it's only some 640 lines. Most of the 3k comes from OAuth 1.0a removal. Since the two PR build on top of each other, and Github counts the total changes wrt the master branch, it looks like this PR is really 3k.

image

9549befa21bcfa16f00f8c89d12822430f0c77ae
 .github/workflows/codeql.yml                       |   2 +-
 CMakeLists.txt                                     |   1 -
 cmake/FindArgon2.cmake                             |  47 -----
 docker/debian/Dockerfile_bookworm                  |   4 +-
 docker/debian/Dockerfile_trixie                    |   4 +-
 docker/ubuntu/Dockerfile                           |   4 +-
 docker/ubuntu/Dockerfile2204                       |   4 +-
 .../backend/apidb/readonly_pgsql_selection.hpp     |   1 -
 include/cgimap/basicauth.hpp                       |  45 -----
 include/cgimap/data_selection.hpp                  |   5 -
 include/cgimap/options.hpp                         |  14 --
 include/cgimap/process_request.hpp                 |   1 -
 src/CMakeLists.txt                                 |   2 -
 src/backend/apidb/readonly_pgsql_selection.cpp     |  36 ----
 src/basicauth.cpp                                  | 193 -------------------
 src/main.cpp                                       |   1 -
 src/options.cpp                                    |   8 -
 src/process_request.cpp                            |   8 +-
 test/CMakeLists.txt                                |  19 --
 test/staticxml.cpp                                 |   1 -
 test/test_apidb_backend_changeset_uploads.cpp      |  37 ++--
 test/test_apidb_backend_changesets.cpp             |  51 ++---
 test/test_basicauth.cpp                            | 213 ---------------------
 test/test_empty_selection.hpp                      |   1 -
 test/test_parse_options.cpp                        |   2 -
 25 files changed, 64 insertions(+), 640 deletions(-)