Fix libxml++ contrib library compiler options

zerebubuth / openstreetmap-cgimap

A C++ implementation of the OpenStreetMap API map call.

http://wiki.openstreetmap.org/wiki/Cgimap

GNU General Public License v2.0

74 stars 38 forks source link

Fix libxml++ contrib library compiler options #398

Closed Woazboat closed 7 months ago

Woazboat commented 7 months ago

Linking the libxml++ contrib library with cgimap_common_compiler_options with INTERFACE scope is a bug as that only applies to targets using the library but not the library itself. (Copy paste error from catch2 which is a header only interface library and can therefore only link to other libraries with INTERFACE scope)

https://github.com/zerebubuth/openstreetmap-cgimap/commit/0901120a963542b457ceb1f45890e18de4b4be88#diff-f3c6529ba39f2f8fe71ba721bdb3eccec46bd4ba024980398b12c7e7cd3f2672R5

mmd-osm commented 7 months ago

I'm a bit curious where this would show up today as an issue. Is it maybe that profiling and coverage would not work for libxml++, or would I notice some other issues?

Woazboat commented 7 months ago

I don't think it currently has any effect other than profiling / coverage. C++17 is the default for >= gcc 11 anyway and the other defines PACKAGE_NAME=..., PACKAGE_VERSION=..., ... that are set aren't used in the libxml++ code. I noticed it because I was testing compilation with C++ 20 and that wasn't applied.

mmd-osm commented 7 months ago

Yes, that makes sense, thanks for your feedback!