dev(narugo): now it supports python3.7

zerex290 / sankaku

Asynchronous API wrapper for Sankaku Complex with type-hinting, pydantic data validation and an optional logging support with loguru.

https://zerex290.github.io/sankaku/

MIT License

8 stars 3 forks source link

dev(narugo): now it supports python3.7 #3

Closed narugo1992 closed 1 year ago

narugo1992 commented 1 year ago

Related to #2

What is changed:

Add support for python3.7~3.10 (I tested 3.7, 3.8 and 3.11 in my own environment, all 80 tests are passed)
Add support for proxy in environment
- If you are using http proxy, just set HTTPS_PROXY (attention that aiohttp does not detect ALL_PROXY)
- If you are using socks proxy, just install sankaku[socks] and then set ALL_PROXY, HTTP_PROXY, HTTPS_PROXY
Add requirements files and put their content into setup.py
Add unittest on github action
Add retries

narugo1992 commented 1 year ago

@zerex290 For issues based on PEP standards, I believe it would be beneficial to establish an automated code reformatter using tools like yapf locally or through services like pre-commit-ci on GitHub. If you already have a configuration file for this, it would be helpful for me to address the code style issues in bulk.

zerex290 commented 1 year ago

@narugo1992 Talking about PEP standarts issues, I skimmed through yapf and found that it takes time to set it up correctly. So I think it's acceptable to skip these PEP issues in actual pull request. In future I will make CONTRIBUTING.md file with description of rules and will pay attention to automatic code reformatters to prevent such situations from happening again. I resolved mentioned issues and left only those that need to be fixed.