search

zericardo / sci-corpus

Scientific corpus manager.
6 stars 1 forks source link

Dim and replace in print PDF #59

Closed dpizetta closed 10 years ago

dpizetta commented 10 years ago

I think it would be better if you put just in bold the the text tha will be held and put in normal font with other color like grey the ohter. Or just put in bold, not red :)

We can use this into the interface too, as an option for replace, in the same way.

tiagocampo commented 10 years ago

For me any color combination is fine. We just have to define a standard! I have done this way just as a prove of concept.

On Tue, Jun 3, 2014 at 1:57 PM, Daniel Pizetta notifications@github.com wrote:

I think it would be better if you put just in bold the the text tha will be held and put in normal font with other color like grey the ohter. Or just put in bold, not red :)

We can use this into the interface too, as an option for replace, in the same way.

— Reply to this email directly or view it on GitHub https://github.com/zericardo182/sci-corpus/issues/59.

Tiago de Campos

dpizetta commented 10 years ago

The problem is:

To make the text be bold, it has to begin with "< b >" and end with "< / b >". The function adjustSentence is not implemented to support different begin/end markers. I will not implement this functionality!

This is not an error or a bug in the exportPDF module, you should open another issue to treat this problem. Thanks tiagocampotiagocampo closed this 11 minutes ago Daniel Pizetta Collaborator dpizetta commented 6 minutes ago The function adjustSentece (from Ze) deal with any kind of markers, inside or outside.

If you mark the option in pdf export to dim and it was marked replace inside markers must be dimmed the part outside, because dim has an opposite functionality from replace!

So if it not working like that, this is a problem in export pdf. … Daniel Pizetta Collaborator dpizetta commented a minute ago To make the text be bold, it has to begin with "< b >" and end with "< / b >" : You just need to change where you put this, and change the name from interface for BOLD not DIM, in this case.

tiagocampo commented 10 years ago

Again, this is a lack of functionality of adjustSentence function.

Contact Zé and ask him to implement a functionality that when the function receives replace_by=dim it will handle every type of situation. I dont understand how this function work and I will not mess with it.

dpizetta commented 10 years ago

And why you close again the task:?

On Mon, Jun 16, 2014 at 11:24 AM, tiagocampo notifications@github.com wrote:

Closed #59 https://github.com/zericardo182/sci-corpus/issues/59.

Reply to this email directly or view it on GitHub https://github.com/zericardo182/sci-corpus/issues/59#event-131742624.

tiagocampo commented 10 years ago

Because the functionality that you want has to be implemented in the adjustSentence function. Not in the pdf_writer module.

On Mon, Jun 16, 2014 at 11:31 AM, Daniel Pizetta notifications@github.com wrote:

And why you close again the task:?

On Mon, Jun 16, 2014 at 11:24 AM, tiagocampo notifications@github.com wrote:

Closed #59 https://github.com/zericardo182/sci-corpus/issues/59.

Reply to this email directly or view it on GitHub https://github.com/zericardo182/sci-corpus/issues/59#event-131742624.

— Reply to this email directly or view it on GitHub https://github.com/zericardo182/sci-corpus/issues/59#issuecomment-46185639 .

Tiago de Campos