zeriontech / Web3Swift

Ethereum Web3 library implementation for Swift
https://web3swift.io
Apache License 2.0
108 stars 32 forks source link

Logs fetching #217

Closed rockfridrich closed 5 years ago

rockfridrich commented 5 years ago

Closes #216

codecov-io commented 5 years ago

Codecov Report

Merging #217 into develop will increase coverage by 1.04%. The diff coverage is 95.26%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #217      +/-   ##
===========================================
+ Coverage    97.71%   98.76%   +1.04%     
===========================================
  Files          319      331      +12     
  Lines        10687    11462     +775     
===========================================
+ Hits         10443    11320     +877     
+ Misses         244      142     -102
Impacted Files Coverage Δ
...sactionLogs/MockedTransactionLogWithTransfer.swift 0% <0%> (ø)
.../Tests/TransactionLog/EthTransactionLogTests.swift 100% <100%> (ø)
Web3Swift/Blocks/EthBlockHash.swift 100% <100%> (ø)
Web3Swift/TransactionHash/EthTransactionHash.swift 100% <100%> (ø) :arrow_up:
Web3Swift/RemoteProcedure/CachedProcedure.swift 100% <100%> (ø)
Example/Tests/BooleanScalar/AndTests.swift 100% <100%> (ø) :arrow_up:
...xample/Tests/Procedures/CachedProcedureTests.swift 100% <100%> (ø)
Web3Swift/Account/EthAutoAccount.swift 100% <100%> (ø) :arrow_up:
Web3Swift/Transaction/EthTransaction.swift 100% <100%> (ø) :arrow_up:
Web3Swift/Blocks/EthBlock.swift 100% <100%> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e4ebe51...f498f81. Read the comment docs.

rockfridrich commented 5 years ago

@biboran could you take a look at this PR. I will rewrite the issue to cover all changes. There are some tests missing but it is ready for general review.

rockfridrich commented 5 years ago

@biboran could you check recent changes?