zeriontech / defi-sdk

DeFi SDK Makes Money Lego Work
https://docs.zerion.io/defi-sdk/
GNU Lesser General Public License v3.0
790 stars 249 forks source link

Maker asssets and loans not working #136

Open valera-shulghin opened 3 years ago

valera-shulghin commented 3 years ago

https://etherscan.io/address/0x78f32a27559170f9a005b319ed53441b9e852158#loansAddress https://app.zerion.io/0x78f32a27559170f9a005b319ed53441b9e852158/overview

This address has Loans and Assets on Maker, but none are returned on getProtocolBalances, or on getBalances.

ojnc commented 3 years ago

I too had the same problem; Maker seems not supported In output of getProtocolNames there is "Maker Governance" but no "Maker" or "Maker Dao"

Tried this code that works for "Compound"

var protocol = "Maker";
defiSdk.getProtocolBalance(account, protocol).then(function (balance) {
    console.log('\n\ngetProtocolBalance "Maker"');
    console.log(JSON.stringify(balance, null, 2));
});

I got exception (node:7444) UnhandledPromiseRejectionWarning: ProtocolDoesNotExistError: Protocol [Maker] does not exists get exception

Please provide solution or workaround

Regards Jayanta

sobolevigor986 commented 3 years ago

hi!

it is called Multi-Collateral Dai and currently supports only ETH and BAT collateral :)