search

zernonia / vue3-notion

An unofficial Notion renderer (Vue 3) version
https://vue3-notion.vercel.app/
MIT License
134 stars 20 forks source link

Title property should be optional #40

Open brachkow opened 1 year ago

brachkow commented 1 year ago

iframes (and some other blocks) have no title property

 '2dd41fb9-8294-4d68-bf76-a4cddc789763': {
      role: 'reader',
      value: {
        id: '2dd41fb9-8294-4d68-bf76-a4cddc789763',
        version: 3,
        type: 'video',
        properties: {
          source: [['https://www.youtube.com/watch?v=jNQXAC9IVRw']],
        },

but it is not optional https://github.com/zernonia/vue3-notion/blob/1e6b447f6d5ce601845d910f8b0ffa22a6f674be/src/lib/types.ts#L57

brachkow commented 1 year ago

value.content should be optional too — it exists only for a title of page, and page as block

brachkow commented 1 year ago

btw all type definitions are not working — see my previous issue https://github.com/zernonia/vue3-notion/issues/30