search

zero-day-labs / riscv-aia

AIA IP compliant with the RISC-V AIA spec
Apache License 2.0
29 stars 7 forks source link

Case inside EIP0:EIP63 #2

Closed KinzaQamar closed 1 year ago

KinzaQamar commented 1 year ago

Hi,

Inside the imsic_top.sv I found a check here. The check should be subtracting the imsic_addr from eip0, no? Why it is subtracting that from eie0 for the case EIP0:EIP63?

Thanks,

D3boker1 commented 1 year ago

Hi Kinza!

You are right! It was a copy-and-paste typo. I will push the fix once I have the opportunity to run it on real hardware to guarantee that everything is running properly.

KinzaQamar commented 1 year ago

Sounds good, thanks!

D3boker1 commented 1 year ago

Fix commit: 183cba2c4929236d13f2f30c75d0513be12ccd13