search

zero-day-labs / riscv-aia

AIA IP compliant with the RISC-V AIA spec
Apache License 2.0
26 stars 7 forks source link

Fixed typos, syntax bugs and wrong file paths in Makefile for aplic(scalable)-imsic test #4

Closed KinzaQamar closed 10 months ago

KinzaQamar commented 1 year ago

This PR includes several fixes related to syntax, typos, and latch errors for Verilator v5.006. Additionally, the PR has only been tested for the configuration for aplic(scalable) with MSI mode.

KinzaQamar commented 10 months ago

@D3boker1

Right now, you have 12 commits in this PR. As I requested before, merge these changes into 3 commits (starting from the current main) and then force push into your branch so we can have a clean history.

Slight confusion. Didn't understand the current main part. I just need to pick and squash commits in interactive mode?

D3boker1 commented 10 months ago

I believe the easiest path would be to fork the repo again, change the code following the commit scheme mentioned above, and force push to your branch (aia_op). But if you find a better way to do it, it is fine for me. The important is to have only that 3 commits, to keep the history clear for others to track changes.

KinzaQamar commented 10 months ago

This PR includes several fixes related to syntax, typos, and latch errors for Verilator v5.006. Additionally, the PR has only been tested for the configuration for aplic(scalable) with MSI mode.

Can you reveiw these changes on a different branch (https://github.com/zero-day-labs/riscv-aia/compare/master...KinzaQamar:riscv-aia:PR)

D3boker1 commented 10 months ago

This PR includes several fixes related to syntax, typos, and latch errors for Verilator v5.006. Additionally, the PR has only been tested for the configuration for aplic(scalable) with MSI mode.

Can you reveiw these changes on a different branch (https://github.com/zero-day-labs/riscv-aia/compare/master...KinzaQamar:riscv-aia:PR)

It looks good to me! Force puch this new branch into the PR branch.

KinzaQamar commented 10 months ago

This PR includes several fixes related to syntax, typos, and latch errors for Verilator v5.006. Additionally, the PR has only been tested for the configuration for aplic(scalable) with MSI mode.

Can you reveiw these changes on a different branch (master...KinzaQamar:riscv-aia:PR)

It looks good to me! Force puch this new branch into the PR branch.

Done!