search

zero-day-labs / riscv-iommu

IOMMU IP compliant with the RISC-V IOMMU Specification v1.0
Apache License 2.0
66 stars 12 forks source link

lint_checks - Mislabeled riscv_iommu ports #2

Closed pcotret closed 1 year ago

pcotret commented 1 year ago

Initial behavior is described in #1 .

There's a small typo in riscv_iommu port names here: https://github.com/zero-day-labs/riscv-iommu/blob/wip/iommu/src/lint_checks.sv

@@ -69,8 +69,8 @@ module lint_checks (
        .r_chan_t           ( ariane_axi_soc::r_chan_t  ),
        .axi_req_t          ( ariane_axi_soc::req_t     ),
        .axi_rsp_t          ( ariane_axi_soc::resp_t    ),
-       .axi_lite_req_t     ( axi_lite_req_t            ),
-       .axi_lite_resp_t    ( axi_lite_resp_t           ),
+       .axi_req_slv_t      ( axi_lite_req_t            ),
+       .axi_rsp_slv_t      ( axi_lite_resp_t           ),
        .reg_req_t          ( reg_req_t                 ),
        .reg_rsp_t          ( reg_rsp_t                 )
    ) i_riscv_iommu (
malejo97 commented 1 year ago

Thanks for the advise @pcotret. I forgot to update the module to perform lint checks on a previous commit. Fixed in commit a0aea44