search

zero-day-labs / riscv-iommu

IOMMU IP compliant with the RISC-V IOMMU Specification v1.0
Apache License 2.0
66 stars 12 forks source link

Some systemVerilog files missing? #3

Closed pcotret closed 8 months ago

pcotret commented 10 months ago

It seems that the repo doesn't have all systemVerilog files of the IOMMU (+ some files are imported from the CVA6 repository).

Furthermore, the Makefile contains hardcoded paths (maybe Manuel's computer).

https://github.com/zero-day-labs/riscv-iommu/blob/11822946183fa991dee980eca73e090773e57396/src/reg_file/test/Makefile#L22

malejo97 commented 10 months ago

Hi @pcotret, thanks for the notice.

The hardcoded paths were actually a mistake in this makefile when I first tried to test the programming interface separately in the beginning of this repo.

However, in 5335be2 I made changes to the structure of the repository and deleted this folder, as we then opted for functional validation of the IP, instead of using cocotb.

Regarding the missing files, I've updated the repo with all required dependencies (SV packages and headers) :)

malejo97 commented 8 months ago

Since there have been no additional comments, I'm considering this issue closed.