Closed saadwaheed-10xe closed 2 months ago
@saadwaheed-10xe Just one last change... Could you rewrite the commits to be signed please?
@saadwaheed-10xe Just one last change... Could you rewrite the commits to be signed please?
The commits are already signed i.e. Signed-off-by: Saad Waheed <saad.waheed@10xengineers.ai>
. Please let me know if something else is required.
@saadwaheed-10xe Just one last change... Could you rewrite the commits to be signed please?
The commits are already signed i.e.
Signed-off-by: Saad Waheed <saad.waheed@10xengineers.ai>
. Please let me know if something else is required.
Sorry @saadwaheed-10xe, GitHub is marking the commits as not being signed. I'll merge the PR anyways
Sorry @saadwaheed-10xe, GitHub is marking the commits as not being signed. I'll merge the PR anyways
Sure, thanks. I think it worked - I can see the merged commits as signed.
Description
This PR has the fixes for unused, undrived and uninitialized RTL signals and a fix for unique case voilation.
Changes
reg_ready
from _rv_iommuregmap.sv since the corresponding signal in register interfacereg_intf_rsp.ready
is hard-wired to 1.tr_req_iova_vpn_l_we
andtr_req_iova_vpn_l_wd
in _rv_iommuregmap.sv.notice_ppn_q
andnotice_nid_q
at reset state in _rv_iommu_mrifhandler.sv.msi_check_error
,translate_pdtp
andmsiptw_active
when MSI transactions are disabled.Contributors
@maarij-10xe @faayez-10xe