[RTL] Fixes for unused and undriven RTL signals

zero-day-labs / riscv-iommu

IOMMU IP compliant with the RISC-V IOMMU Specification v1.0

Apache License 2.0

66 stars 12 forks source link

[RTL] Fixes for unused and undriven RTL signals #9

Closed saadwaheed-10xe closed 2 months ago

saadwaheed-10xe commented 2 months ago

Description

This PR has the fixes for unused, undrived and uninitialized RTL signals and a fix for unique case voilation.

Changes

Removed unused signal reg_ready from _rv_iommuregmap.sv since the corresponding signal in register interface reg_intf_rsp.ready is hard-wired to 1.
Removed multi-driven signals tr_req_iova_vpn_l_we and tr_req_iova_vpn_l_wd in _rv_iommuregmap.sv.
Initialized registers notice_ppn_q and notice_nid_q at reset state in _rv_iommu_mrifhandler.sv.
Fixed unique case violation "Every case item expression was false" in _errorrouting block by adding a default statement.
Fixed unassigned signals msi_check_error, translate_pdtp and msiptw_active when MSI transactions are disabled.

Contributors

@maarij-10xe @faayez-10xe

malejo97 commented 2 months ago

Thanks for applying the changes @saadwaheed-10xe ! Could you please rewrite the commit history to "merge" all modifications within the regmap in a single commit? (i.e., merge da316ff and daeabd3)

saadwaheed-10xe commented 2 months ago

Thanks for applying the changes @saadwaheed-10xe ! Could you please rewrite the commit history to "merge" all modifications within the regmap in a single commit? (i.e., merge da316ff and daeabd3)

Done, I have merged the regmap changes in a single commit.

malejo97 commented 2 months ago

@saadwaheed-10xe Just one last change... Could you rewrite the commits to be signed please?

saadwaheed-10xe commented 2 months ago

@saadwaheed-10xe Just one last change... Could you rewrite the commits to be signed please?

The commits are already signed i.e. Signed-off-by: Saad Waheed <saad.waheed@10xengineers.ai>. Please let me know if something else is required.

malejo97 commented 2 months ago

@saadwaheed-10xe Just one last change... Could you rewrite the commits to be signed please?

The commits are already signed i.e. Signed-off-by: Saad Waheed <saad.waheed@10xengineers.ai>. Please let me know if something else is required.

Sorry @saadwaheed-10xe, GitHub is marking the commits as not being signed. I'll merge the PR anyways

saadwaheed-10xe commented 2 months ago

Sorry @saadwaheed-10xe, GitHub is marking the commits as not being signed. I'll merge the PR anyways

Sure, thanks. I think it worked - I can see the merged commits as signed.