zero-one-group / geni

A Clojure dataframe library that runs on Spark
Apache License 2.0
284 stars 28 forks source link

Add steps for setup data for performance testing #247

Closed agilecreativity closed 3 years ago

agilecreativity commented 3 years ago

Hi @anthony-khong

This PR add the steps required to properly run the code via the REPL. I think this is required so that the data is available during session.

I basically duplicate the code that you had from the example code as I can't use it directly due to the namespace issue.

Please let me know if you need me to update anything. Or please feel free to adjust if you like.

Thanks, Burin

codecov-io commented 3 years ago

Codecov Report

Merging #247 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##            develop       #247   +/-   ##
===========================================
  Coverage   100.000%   100.000%           
===========================================
  Files            34         34           
  Lines          2658       2658           
===========================================
  Hits           2658       2658           
anthony-khong commented 3 years ago

Thank you! Indeed, that part of the cookbook is less straightforward than the other parts, because of the data it uses. Thank you for addressing it!