zero-one-group / geni

A Clojure dataframe library that runs on Spark

Apache License 2.0

284 stars 28 forks source link

Fix the call to the function to get data #322

Closed burinc closed 3 years ago

burinc commented 3 years ago

Hi @anthony-khong

This is simple fix to some of the examples/documents that use melbourne-df function.

The changes in markdown file are not intended but my Emacs just re-format it for me.

Best,

anthony-khong commented 3 years ago

Thanks for thisg @burinc! Hmm, would you be happy to put a note that melbourne-df is a function that loads the df in the README? I don't want people to confuse that example with the general way of interacting with the df (i.e. with the parens).

burinc commented 3 years ago

Sure, I can. Let's update this to make it clear for everyone.

codecov-io commented 3 years ago

Codecov Report

Merging #322 (515556c) into develop (dbfd287) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##           develop      #322   +/-   ##
=========================================
  Coverage   99.967%   99.967%           
=========================================
  Files           36        36           
  Lines         3084      3084           
=========================================
  Hits          3083      3083           
  Misses           1         1

burinc commented 3 years ago

Hi Anthony, In the last commit, I update one dependency to see if I can get a green check for linter. I hope it is ok with you. If not I can revert this change and create a separate PR to get this in. Best,

anthony-khong commented 3 years ago

@burinc apologies for the delay, I forgot about this PR!