zero-one-group / geni

A Clojure dataframe library that runs on Spark
Apache License 2.0
281 stars 28 forks source link

Allow structs and list of structs in g/->dataset (#335) #336

Closed WaqasAliAbbasi closed 2 years ago

WaqasAliAbbasi commented 2 years ago

Fixes #335, Works well for:

It's recursive so it supports maps inside maps as well.

Caveats for list of maps

^Resolved the above caveats

codecov-commenter commented 2 years ago

Codecov Report

Merging #336 (0ca9f3f) into develop (e3c88ad) will decrease coverage by 0.127%. The diff coverage is 89.743%.

Impacted file tree graph

@@              Coverage Diff              @@
##           develop      #336       +/-   ##
=============================================
- Coverage   99.967%   99.839%   -0.128%     
=============================================
  Files           36        36               
  Lines         3085      3118       +33     
  Branches         0         4        +4     
=============================================
+ Hits          3084      3113       +29     
  Misses           1         1               
- Partials         0         4        +4     
Impacted Files Coverage Δ
...rc/clojure/zero_one/geni/core/dataset_creation.clj 97.590% <89.743%> (-2.410%) :arrow_down:
anthony-khong commented 2 years ago

Thank you @WaqasAliAbbasi! I'll make a new release today!