Closed skylee03 closed 9 months ago
Thanks for this @skylee03, I wasn't expecting this! I'm not sure why the Actions are not running. I'll try to find a way to run it, and if all the checks pass, then let's merge it!
I'm going to try and close and reopen this as I changed some of the Actions config.
@skylee03 I hope the failing test should be easy-ish to fix?
Also, would you be happy to make the same project.clj
changes to the Lein template in lein-template/resources/leiningen/new/geni/project.clj
as well?
@skylee03 I hope the failing test should be easy-ish to fix?
Also, would you be happy to make the same
project.clj
changes to the Lein template inlein-template/resources/leiningen/new/geni/project.clj
as well?
👌
Merging #346 (f87d3fd) into develop (b616f02) will not change coverage. The diff coverage is
n/a
.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@ Coverage Diff @@
## develop #346 +/- ##
=========================================
Coverage 99.839% 99.839%
=========================================
Files 36 36
Lines 3118 3118
Branches 4 4
=========================================
Hits 3113 3113
Misses 1 1
Partials 4 4
I found that some dependencies in lein-template/resources/leiningen/new/geni/project.clj
are newer than those in project.clj
. Should I also update the dependencies in project.clj
to the same versions?
Yes, please, if you could that, that would be fantastic, thanks! Happy to merge this after that.
Thank you again for your contribution! I'll prepare a 0.0.41 release.
--add-opens
JVM options to get rid of "cannot access class" errors