zero-to-mastery / Keiko-Corp

HTML challenge for Hacktoberfest 2020

https://keiko-corp.netlify.app/

MIT License

207 stars 371 forks source link

Add logo to blog and link to home #790

Closed SimulatedPanda closed 4 years ago

SimulatedPanda commented 4 years ago

Pull Request Template

Please provide all of the details below. Pull requests missing any of the information below will be closed! Providing the issue number/url helps us identify the problem being solved and keep the issues tab clean and tidy

This is not a fix. This is a request to add login and signup pages to the site.

Summarize what this PR fixes:- Adds the Keiko logo and link home to the Blog page of the site.

Fixes #787

Checklist

(Add an x between the brackets to check the items)

[x] I have summarize what this PR fixes above
[x] I have provided the issue ID/URL above
[x] I have not added Bootstrap or jQuery and used correct styling guide.
[x] This PR fixes only the issue mentioned above (create separate PRs for separate issues)
[x] I was the first one to claim the issue or I created the issue - I created the issue

zero-to-mastery-bot[bot] commented 4 years ago

🙏 Thanks for your pull request @SimulatedPanda, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number:	➕ Line Additions:	🗑️ Line Deletions:
790	10	4

📑 Files Changed:	⭐ Repo Stars:	🔱 Total Forks:
2	187	365

brittneypostma commented 4 years ago

Again, styles and typos in comments should not be changed, no logo image is actually in the blog page as the issue suggests.

SimulatedPanda commented 4 years ago

Sorry!

I'm new to this (as you can tell). There is currently no logo on the blog page. My intention was to add it in and link it to the homepage. Guessing I didn't succeed?

On Sat, 17 Oct 2020, 10:08 am Brittney Postma, notifications@github.com wrote:

Again, styles and typos in comments should not be changed, no logo image is actually in the blog page as the issue suggests.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/zero-to-mastery/Keiko-Corp/pull/790#issuecomment-710637843, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARKYP67O6VVSULILZBK22Q3SLCY6HANCNFSM4SSWLOIA .