search

zero-to-mastery / Keiko-Corp

HTML challenge for Hacktoberfest 2020
https://keiko-corp.netlify.app/
MIT License
207 stars 371 forks source link

my info to the contibutors.md file #814 #815

Closed WayneMacMavis closed 4 years ago

WayneMacMavis commented 4 years ago

Pull Request Template

Please provide all of the details below. Pull requests missing any of the information below will be closed! Providing the issue number/url helps us identify the problem being solved and keep the issues tab clean and tidy

814

Summarize what this PR fixes:-

Fixes # It updates the contributors file with my details

Checklist

(Add an x between the brackets to check the items)

zero-to-mastery-bot[bot] commented 4 years ago

🙏 Thanks for your pull request @WayneMacMavis, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
815 1 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
1 190 377
brittneypostma commented 4 years ago

I will be happy to merge this if you can provide me with previous issues you've resolved. It is against hacktoberfest policy to just add your name to contributors, so I need to see previous work done.

zero-to-mastery-bot[bot] commented 4 years ago

🙏 Thanks for your pull request @WayneMacMavis, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
815 1 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
1 190 381
zero-to-mastery-bot[bot] commented 4 years ago

🙏 Thanks for your pull request @WayneMacMavis, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
815 1 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
1 190 381
WayneMacMavis commented 4 years ago

@brittneypostma Ok i understand. I just did some small fixes like the button colors when hovering and the darkmode toggle button when it was broken. But it's not super crucial that i be added to the contributors list. Just thought it was a simple thing because i did contribute. So no worries

brittneypostma commented 4 years ago

Ok, I just need to check them. I can merge it in.

WayneMacMavis commented 4 years ago

Thank you @brittneypostma, It is much appreciated. Boy! they are strict this year. Last year it was quite easy to do. This year not so much. I guess they want people to actually work for it.