zero-to-mastery / Keiko-Corp

HTML challenge for Hacktoberfest 2020
https://keiko-corp.netlify.app/
MIT License
207 stars 371 forks source link

Improving site #845

Closed YahyaFazlani closed 4 years ago

YahyaFazlani commented 4 years ago

Fixes issue #839

Added login link to contact and login page Improved the active class removed hover effect from dark mode toggle Moved the scroll class to nav-styles.css from contacts.css

zero-to-mastery-bot[bot] commented 4 years ago

🙏 Thanks for your pull request @YahyaFazlani, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
845 52 38
📑 Files Changed: Repo Stars: 🔱 Total Forks:
8 192 386
brittneypostma commented 4 years ago

There are conflicts that need to be resolved. There are too many things changing at one time. We should do pr's for one change at a time. If you can resolve the conflicts, I'll take a look at the changes.

zero-to-mastery-bot[bot] commented 4 years ago

⚠️ MERGE CONFLICT DETECTED!

@YahyaFazlani A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, there are tons of guides on Google and Youtube to help you out. If you get stuck ask over on Discord.

zero-to-mastery-bot[bot] commented 4 years ago

⚠️ MERGE CONFLICT DETECTED!

@YahyaFazlani A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, there are tons of guides on Google and Youtube to help you out. If you get stuck ask over on Discord.

zero-to-mastery-bot[bot] commented 4 years ago

🙏 Thanks for your pull request @YahyaFazlani, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
845 47 45
📑 Files Changed: Repo Stars: 🔱 Total Forks:
8 192 387
zero-to-mastery-bot[bot] commented 4 years ago

🙏 Thanks for your pull request @YahyaFazlani, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
845 47 45
📑 Files Changed: Repo Stars: 🔱 Total Forks:
8 192 387
YahyaFazlani commented 4 years ago

There are conflicts that need to be resolved. There are too many things changing at one time. We should do pr's for one change at a time. If you can resolve the conflicts, I'll take a look at the changes.

Sorry, I am newcomer to open-source. Will make better pull requests next time.