zero-to-mastery / Keiko-Corp

HTML challenge for Hacktoberfest 2020
https://keiko-corp.netlify.app/
MIT License
206 stars 371 forks source link

Sticky Nav in Blog Page is Transparent #888

Closed sdangoy closed 3 years ago

sdangoy commented 3 years ago

New Mockup

Please check assets/css/global.css, design-assets folder images, and figma files for updated style guides. Any new pull request should use the updated color, spacing, and sizing variables.

No Bootstrap or jQuery

Please refrain from adding Bootstrap or jQuery to the site. These pr's will be closed. They overwrite global styles. Vanilla CSS and JS is way better now anyways 😊

New Task:

What is the task

The sticky nav is transparent because of a different class used to style it. I'll change the incorrect class for the nav-bar and replace it with the correct class.

EDIT: By changing the nav and sticky nav to the nav used on the homepage, the formatting of the blog page was completely messed up. I had to reorganize the styling of the page to fix this.

Who is the task for?

Confirm all of the following:


⚠️ PLEASE ONLY SUBMIT A PR FOR THIS TASK IF THIS TASK WAS AVAILABLE FOR YOU TO CLAIM

dhakshinesh commented 3 years ago

A quick suggestion: you can use z-index to bring the navbar forward!!

sdangoy commented 3 years ago

Thanks for the suggestion @dhakshinesh